JSON config > + `additional_languages` & `stop_code_cleaners` by mmathieum · Pull Request #66 · mtransitapps/parser

mmathieum · 2026-05-06T17:57:03Z

Cleanup... ca-montreal-stm-subway-android#7

gemini-code-assist

Code Review

This pull request introduces support for additional languages in the agency configuration and implements stop code cleaning logic. The changes include updates to language retrieval and the addition of a cleaning step for stop codes. Feedback focuses on ensuring consistent return values for language lists, applying stop code cleaning to all source fields, and optimizing the performance of language merging to avoid redundant object creation and duplicates.

I am having trouble creating individual review comments. Click here to see my feedback.

src/main/java/org/mtransit/parser/DefaultAgencyTools.java (204-208)

The current implementation is inconsistent regarding the return value when no languages are supported. If agencyConfig is present but the list is empty, getAllLanguages returns null. However, if agencyConfig is absent, it returns this.supportedLanguages (which is an empty list). To maintain consistency with the @Nullable annotation and previous behavior (where null signified that no languages were set), it should return null when the list is empty in both branches.

		if (Configs.getAgencyConfig() != null) {
			return Configs.getAgencyConfig().getAllLanguages(this.supportedLanguages);
		}
		return this.supportedLanguages.isEmpty() ? null : this.supportedLanguages;

src/main/java/org/mtransit/parser/DefaultAgencyTools.java (1276-1278)

The stop_code_cleaners should be applied to the final stop code value, regardless of whether it originates from the stop_code or stop_id field (when use_stop_id_for_stop_code is enabled). This ensures that any cleaning logic defined in the configuration is consistently applied to the value displayed as the stop code in the UI.

		final String stopCode = cleanStopCode(
				Configs.getRouteConfig().getUseStopIdForStopCode() ? gStop.getStopId() : gStop.getStopCode()
		);

src/main/java/org/mtransit/parser/config/gtfs/data/AgencyConfig.kt (65-68)

This method is called frequently during the parsing process (e.g., for every route and stop name cleaning). Repeatedly mapping additionalLanguages to Locale objects and creating new lists via the + operator is inefficient. Additionally, additionalLanguages might contain duplicates of supportedLanguages, which should be handled to avoid redundant processing downstream. Caching the merged list or at least the additionalLanguages locales would significantly improve performance.

    fun getAllLanguages(supportedLanguages: List<Locale>?): List<Locale>? {
        if (supportedLanguages.isNullOrEmpty()) return null
        if (additionalLanguages.isEmpty()) return supportedLanguages
        return (supportedLanguages + additionalLanguages.map { Locale.forLanguageTag(it) }).distinct()
    }

Copilot

Pull request overview

This PR extends the GTFS JSON configuration surface to support (1) expanding an agency’s supported languages via additional_languages, and (2) applying configurable stop-code cleanup via stop_code_cleaners, then wires these features into DefaultAgencyTools.

Changes:

Add AgencyConfig.additional_languages and merge it into the tool’s supported languages list.
Add RouteConfig.stop_code_cleaners + cleanStopCode() and apply it in DefaultAgencyTools.getStopCode().
Minor clarification comment in GReader about reading agency first to set up languages.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/main/java/org/mtransit/parser/gtfs/GReader.java	Clarifies agency read ordering for language setup.
src/main/java/org/mtransit/parser/DefaultAgencyTools.java	Merges additional languages (cached) and cleans stop codes via route config.
src/main/java/org/mtransit/parser/config/gtfs/data/RouteConfig.kt	Adds `stop_code_cleaners` and `cleanStopCode()` helper.
src/main/java/org/mtransit/parser/config/gtfs/data/AgencyConfig.kt	Adds `additional_languages` and helper to merge with GTFS-provided languages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

mmathieum · 2026-05-06T19:39:57Z

/gemimi review

mmathieum · 2026-05-06T23:10:24Z

/gemini review

gemini-code-assist

Code Review

This pull request implements a caching mechanism for supported languages in DefaultAgencyTools and introduces stop code cleaning capabilities. The review feedback identifies concurrency issues in the caching logic, recommending the use of volatile and a more robust access pattern to prevent race conditions. Other suggestions include adhering to the Google Java Style Guide by using braces for all if statements and improving code formatting for better readability.

- commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

- commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons: Merge branch 'master' of github.com:mtransitapps/commons - commons: README > HTTPS for apache.org - commons: Build(deps): Bump android-gradlePlugin from 9.2.0 to 9.2.1 mtransitapps/commons#728 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-android: cleanup - commons-android: GTFS RT > Trip Updates > cache no data & trip ID out of sync log... mtransitapps/commons-android#140 - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons: Merge branch 'master' of github.com:mtransitapps/commons - commons: README > HTTPS for apache.org - commons: Build(deps): Bump android-gradlePlugin from 9.2.0 to 9.2.1 mtransitapps/commons#728 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-android: cleanup - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons: Merge branch 'master' of github.com:mtransitapps/commons - commons: README > HTTPS for apache.org - commons: Build(deps): Bump android-gradlePlugin from 9.2.0 to 9.2.1 mtransitapps/commons#728 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-android: cleanup - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons: Merge branch 'master' of github.com:mtransitapps/commons - commons: README > HTTPS for apache.org - commons: Build(deps): Bump android-gradlePlugin from 9.2.0 to 9.2.1 mtransitapps/commons#728 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-android: cleanup - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons: Merge branch 'master' of github.com:mtransitapps/commons - commons: README > HTTPS for apache.org - commons: Build(deps): Bump android-gradlePlugin from 9.2.0 to 9.2.1 mtransitapps/commons#728 - commons: Remove deprecated `GrandRiverTransitProvider` mtransitapps/commons#726 - commons: Remove deprecated `OCTranspoProvider` mtransitapps/commons#725 - commons: Remove deprecated `CaTransLinkProvider` mtransitapps/commons#724 - commons: Build(deps): Bump android-gradlePlugin from 9.1.1 to 9.2.0 mtransitapps/commons#702 - commons: Remove deprecated `StrategicMappingProvider` mtransitapps/commons#723 - commons: Remove deprecated `GreaterSudburyProvider` mtransitapps/commons#722 - commons: Remove deprecated `CaSTOProvider` mtransitapps/commons#721 - commons: Remove deprecated LTC online provider mtransitapps/commons#720 - commons: chore: remove deprecated CaEdmontonProvider mtransitapps/commons#719 - commons: Build(deps): Bump org.sonarqube from 7.2.3.7755 to 7.3.0.8198 mtransitapps/commons#718 - commons: Build(deps): Bump gradle-wrapper from 9.4.1 to 9.5.0 in /shared mtransitapps/commons#717 - commons: GTFS-RT > fix time-zone compat mtransitapps/commons#716 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-android: cleanup - commons-android: GTFS RT > Trip Updates > cache no data & trip ID out of sync log... mtransitapps/commons-android#140 - commons-android: GTFS-RT > Alerts/Vehicles > log trip IDs out of sync! - commons-android: GTFS-RT > Trip Updates > info log for NO trip IDs - commons-android: GTFS-RT > Trip Updates > info log for trip IDs - commons-android: Remove deprecated `GrandRiverTransitProvider` mtransitapps/commons-android#139 - commons-android: Remove deprecated `OCTranspoProvider` mtransitapps/commons-android#138 - commons-android: Update GTFS Real-Time proto mtransitapps/commons-android#137 - commons-android: Remove deprecated `CaTransLinkProvider` mtransitapps/commons-android#136 - commons-android: Fix ThreadConstraint for AGP `9.2.0` mtransitapps/commons-android#126 - commons-android: Remove deprecated `StrategicMappingProvider` mtransitapps/commons-android#135 - commons-android: Remove deprecated `GreaterSudburyProvider` mtransitapps/commons-android#134 - commons-android: Remove deprecated `CaSTOProvider` mtransitapps/commons-android#133 - commons-android: Remove deprecated LTC online provider mtransitapps/commons-android#132 - commons-android: Remove deprecated CaEdmontonProvider mtransitapps/commons-android#131 - commons-android: Delete unused/useless `JCDecauxBikeStationProvider` mtransitapps/commons-android#130 - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - commons-java: Remove deprecated `GreaterSudburyProvider` mtransitapps/commons-java#33 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66 - parser: tests++ - parser: Route long name merging improvement mtransitapps/parser#65 - parser: Revert "Route long name merging improvement" - parser: Route long name merging improvement - parser: Remove deprecated `StrategicMappingProvider` mtransitapps/parser#64

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons: Merge branch 'master' of github.com:mtransitapps/commons - commons: README > HTTPS for apache.org - commons: Build(deps): Bump android-gradlePlugin from 9.2.0 to 9.2.1 mtransitapps/commons#728 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-android: cleanup - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

…parser': - commons: Store listing > feature graphics > 1-line max length tweak - commons: Add push trigger on `config/input_url` and `config/input_url_next` to mt-download-data workflow mtransitapps/commons#733 - commons: Store listing > full/short desc > compat w/ `api.stm.info` provider mtransitapps/commons#732 - commons: Encrypt file > auto dest file path from source - commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons: Update GTFS Validator from `7.0.0` to `8.0.0` mtransitapps/commons#729 - commons: Build(deps): Bump com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk from 1.0.0 to 1.0.1 mtransitapps/commons#727 - commons: Merge branch 'master' of github.com:mtransitapps/commons - commons: README > HTTPS for apache.org - commons: Build(deps): Bump android-gradlePlugin from 9.2.0 to 9.2.1 mtransitapps/commons#728 - commons-android: `api.stm.info` GTFS-RT like provider > + service update : regex for severity⬜ℹ️⚠️ override mtransitapps/commons-android#142 - commons-android: FR `Horaire`... mtransitapps/commons-android#141 - commons-android: cleanup - commons-java: Source label: hide host `google.com` mtransitapps/commons-java#35 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: Missing route colors > do not fix colors from JSON config. - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66

JSON config > + additional_languages & stop_code_cleaners

dc32f2c

mmathieum self-assigned this May 6, 2026

mmathieum marked this pull request as ready for review May 6, 2026 17:57

mmathieum mentioned this pull request May 6, 2026

Cleanup... mtransitapps/ca-montreal-stm-subway-android#7

Merged

5 tasks

gemini-code-assist Bot reviewed May 6, 2026

View reviewed changes

PR comments

7591554

mmathieum requested a review from Copilot May 6, 2026 19:18

Copilot started reviewing on behalf of mmathieum May 6, 2026 19:18 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

Potential fix for pull request finding

ab7ed2d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

gemini-code-assist Bot reviewed May 6, 2026

View reviewed changes

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

Comment thread src/main/java/org/mtransit/parser/DefaultAgencyTools.java

mmathieum merged commit 41ff53f into master May 6, 2026
4 checks passed

mmathieum deleted the mm/add_lang_stop_code_cleaners branch May 6, 2026 23:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JSON config > + `additional_languages` & `stop_code_cleaners`#66

JSON config > + `additional_languages` & `stop_code_cleaners`#66
mmathieum merged 3 commits intomasterfrom
mm/add_lang_stop_code_cleaners

mmathieum commented May 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmathieum commented May 6, 2026

Uh oh!

mmathieum commented May 6, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mmathieum commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

src/main/java/org/mtransit/parser/DefaultAgencyTools.java (204-208)

src/main/java/org/mtransit/parser/DefaultAgencyTools.java (1276-1278)

src/main/java/org/mtransit/parser/config/gtfs/data/AgencyConfig.kt (65-68)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmathieum commented May 6, 2026

Uh oh!

mmathieum commented May 6, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mmathieum commented May 6, 2026 •

edited

Loading